Vojtech Szocs has posted comments on this change. Change subject: ui: line chart progress bar ......................................................................
Patch Set 14: Code-Review+2 (1 comment) Patch looks good. http://gerrit.ovirt.org/#/c/29549/14/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/LineChartProgressBarColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/LineChartProgressBarColumn.java: Line 67: Line 68: @Override Line 69: public SafeHtml getValue(T object) { Line 70: if (canvas == null) { Line 71: // lazily - normally the browser should support it AFAIK, IE8 doesn't support canvas but IE9+ does. All modern browsers should support canvas. Line 72: if (fallbackProgressColumn == null) { Line 73: fallbackProgressColumn = new FallbackProgressColumn(); Line 74: } Line 75: -- To view, visit http://gerrit.ovirt.org/29549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66a577d6e3699c7985a4e6dd4aa66dd5969ebf82 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
