Sahina Bose has posted comments on this change. Change subject: engine: Adding dao and sp for geo-replication ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/30823/3/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java: Line 94: public void testGetById() { Line 95: GlusterGeoRepSession session = dao.getById(FixturesTool.GLUSTER_GEOREP_SESSION_ID); Line 96: assertNotNull(session); Line 97: assertEquals(FixturesTool.GLUSTER_GEOREP_SESSION_ID, session.getId()); Line 98: } > No test cases for negative cases Will add test cases for get with invalid id..Not much logic in dao for negative tests Line 99: Line 100: http://gerrit.ovirt.org/#/c/30823/3/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 6767: <value>dumping</value> Line 6768: <value>["192.168.122.18", 2222]</value> Line 6769: </row> Line 6770: </table> Line 6771: > TWS Done Line 6772: <table name="gluster_georep_session"> Line 6773: <column>session_id</column> Line 6774: <column>master_volume_id</column> Line 6775: <column>session_key</column> http://gerrit.ovirt.org/#/c/30823/3/packaging/dbscripts/gluster_georep_sp.sql File packaging/dbscripts/gluster_georep_sp.sql: Line 7: ----------------------------------------------------------------*/ Line 8: Line 9: Create or replace FUNCTION InsertGlusterGeoRepSession(v_session_id UUID, Line 10: v_master_volume_id UUID, Line 11: v_session_key VARCHAR(150), > Remove the noise because of spaces Done Line 12: v_slave_host_name VARCHAR(50), Line 13: v_slave_host_uuid UUID, Line 14: v_slave_volume_name VARCHAR(50), Line 15: v_slave_volume_id UUID, Line 95: FROM gluster_georep_session Line 96: WHERE session_key = v_session_key; Line 97: END; $procedure$ Line 98: LANGUAGE plpgsql; Line 99: > U may need an update procedure for Session details. Session details contain Done Line 100: Create or replace FUNCTION UpdateGlusterGeoRepSessionStatus(v_session_id UUID, Line 101: v_status VARCHAR(50)) Line 102: RETURNS VOID Line 103: AS $procedure$ -- To view, visit http://gerrit.ovirt.org/30823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ab2ee5044604c0af8fd791061e991c9d50617c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
