Ori Liel has posted comments on this change. Change subject: restapi: Fix NPE when live migrating a disk ......................................................................
Patch Set 4: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/30975/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java: Line 67: @Override Line 68: public Response move(Action action) { Line 69: validateParameters(action, "storageDomain.id|name"); Line 70: Guid storageDomainId = getStorageDomainId(action); Line 71: Disk disk = get(); It seems wrong to me to force the API layer to pass a parameter to the Engine, which the Engine is capable of inferring on it's own. Since this is the existing API between the API layer and the Engine, I don't mind acking this change (so that the underlying bug may be solved) but please open a lower priority bug requesting to change the API between the API-layer and the Engine and remove source-storage-domain from MoveDiskParameters. Line 72: Guid imageId = asGuid(disk.getImageId()); Line 73: Guid sourceStorageDomainId = getSourceStorageDomainId(disk); Line 74: MoveDisksParameters params = Line 75: new MoveDisksParameters(Collections.singletonList(new MoveDiskParameters( -- To view, visit http://gerrit.ovirt.org/30975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
