Liron Aravot has posted comments on this change. Change subject: core: Calculate storage format when adding an SD ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/30960/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java: Line 152: ensureStorageFormatInitialized(); Line 153: if (!isStorageFormatSupportedByStoragePool() || !isStorageFormatCompatibleWithDomain()) { Line 154: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST); Line 155: getReturnValue().getCanDoActionMessages().add( Line 156: String.format("$storageFormat %1$s", getStorageDomain().getStorageFormat())); let's fix this message regardless, right now null will be shown as the format Line 157: return false; Line 158: } Line 159: return canAddDomain(); Line 160: } -- To view, visit http://gerrit.ovirt.org/30960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If469bb655e9a65e2d0afcee164655fa0bdfa5d99 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
