Alon Bar-Lev has posted comments on this change.
Change subject: build: use maven deploy and move jar handling to Makefile
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File Makefile
Line 68: $(BUILD_FILE):
Oh... now I understand.
This was how it was...
And... most importantly... We use:
make all
make install
In two phases of the spec file so we need make install not to try to rebuild.
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 312: make PREFIX=%{buildroot} javadir=%{_javadir}
mavenpomdir=%{_mavenpomdir} install
I guess it depends whose eye is it :)
OK, I will change this.
--
To view, visit http://gerrit.ovirt.org/6171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb8b8f60f2be71b2054582b5e898ae996f324ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
