Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Prevent more than one dwh per engine ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/31325/5/packaging/setup/ovirt_engine_setup/dwh/engine_db_timekeeping.py File packaging/setup/ovirt_engine_setup/dwh/engine_db_timekeeping.py: Line 20: _ = lambda m: gettext.dgettext(message=m, domain='ovirt-engine-dwh') Line 21: Line 22: Line 23: from otopi import util Line 24: > 2 lines Done Line 25: DB_KEY_RUNNING = 'DwhCurrentlyRunning' Line 26: DB_KEY_HOSTNAME = 'dwhHostname' Line 27: DB_KEY_UUID = 'dwhUuid' Line 28: http://gerrit.ovirt.org/#/c/31325/5/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/db/single_etl.py File packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/db/single_etl.py: Line 52: engine_db_timekeeping.updateTimekeeping( Line 53: statement=statement, Line 54: name=engine_db_timekeeping.DB_KEY_UUID, Line 55: value='' Line 56: ) > else? Relevant flow: engine setup on host A dwh setup on host B dwh setup on host C user replies 'Yes' to 'disconnect existing dwh on host B?' engine-cleanup ran on host B We only check this in validation in setup. Can add also on remove, not sure it's important. Do you think a user being asked about this will want to abort remove? I think we can add a warning here if at all. Line 57: Line 58: -- To view, visit http://gerrit.ovirt.org/31325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c0bbeef7fbd809895f4f0c1addd36e13f4894a6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
