Allon Mureinik has posted comments on this change.
Change subject: core: Change reconstruct flow
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/dbscripts/upgrade/03_01_1280_add_last_time_used_as_master_col.sql
Line 1: select fn_db_add_column('storage_domain_static',
'last_time_used_as_master', 'BIGINT');
You give no default value here, but it seems the code later on (e.g., the
comparator) assumes there is a value here.
Am I mistaken?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 168: // reset cache and mark reconstruct for pool as finished
why?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 288: Collections.sort(storageDomains, new
LastTimeUsedAsMasterComp());
This doesn't feel right - why not have the database sort them properly for you?
--
To view, visit http://gerrit.ovirt.org/6066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie95c014b232e9a929f988a115c824d9960f9a290
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
