Lior Vernia has posted comments on this change. Change subject: webadmin: Implement validation in EntityModelCellTable ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31324/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java: Line 314: String error = errors.get(i); Line 315: Element element = getRowElement(i); Line 316: boolean valid = StringUtils.isEmpty(error); Line 317: element.setTitle(valid ? null : error); Line 318: element.getStyle().setOutlineStyle(valid ? OutlineStyle.NONE : OutlineStyle.SOLID); > Instead of setting styles on the element like this I suggest you use css cl Done Line 319: element.getStyle().setOutlineColor("red"); //$NON-NLS-1$ Line 320: element.getStyle().setOutlineWidth(1, Unit.PX); Line 321: } Line 322: } -- To view, visit http://gerrit.ovirt.org/31324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cddd3a6dbfe3cd9b18b631f4da13865b367d096 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
