Sahina Bose has posted comments on this change. Change subject: engine: Added tables for geo replication entities ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/29947/4/packaging/dbscripts/upgrade/03_06_0080_gluster_georep_tables.sql File packaging/dbscripts/upgrade/03_06_0080_gluster_georep_tables.sql: Line 4: session_id UUID NOT NULL, Line 5: master_volume_id UUID NOT NULL, Line 6: session_key VARCHAR(150) NOT NULL, Line 7: slave_host_uuid UUID, Line 8: slave_host_name VARCHAR(50), > TWS, please remove Done Line 9: slave_volume_id UUID, Line 10: slave_volume_name VARCHAR(50), Line 11: status VARCHAR, Line 12: _create_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 6: session_key VARCHAR(150) NOT NULL, Line 7: slave_host_uuid UUID, Line 8: slave_host_name VARCHAR(50), Line 9: slave_volume_id UUID, Line 10: slave_volume_name VARCHAR(50), > TWS, please remove Done Line 11: status VARCHAR, Line 12: _create_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 13: _update_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 14: CONSTRAINT pk_gluster_georep_session PRIMARY KEY(session_id) Line 17: Line 18: -- Add gluster_georep_config Line 19: CREATE TABLE gluster_georep_config Line 20: ( Line 21: session_id UUID NOT NULL REFERENCES gluster_georep_session(session_id) ON DELETE CASCADE, > I prefer defining FK explicitly and giving them proper named , see your las Done Line 22: config_key VARCHAR(50), Line 23: config_value VARCHAR(50), Line 24: _update_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 25: CONSTRAINT pk_gluster_georep_config PRIMARY KEY(session_id, config_key) Line 44: CONSTRAINT pk_gluster_georep_session_details PRIMARY KEY(session_id, master_brick_id) Line 45: ) WITH OIDS; Line 46: Line 47: ALTER TABLE ONLY gluster_georep_session Line 48: ADD CONSTRAINT fk_gluster_georep_session_vol_id FOREIGN KEY (master_volume_id) REFERENCES gluster_volumes(id) ON DELETE CASCADE; > Related to my previous comment K. -- To view, visit http://gerrit.ovirt.org/29947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I231092cfc969030e144a7ddd08187ce1c47a29db Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
