Omer Frenkel has posted comments on this change. Change subject: core: osinfo - extract a validation method ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31372/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java: Line 62: log.debugFormat("Osinfo Repository:\n {0}", toString()); Line 63: } Line 64: } Line 65: Line 66: private void validateTree() { not sure i understand this change, what is the difference now between validateTree() and validateUniqueNames() ?feels like one is redundant Line 67: try { Line 68: validateUniqueNames(); Line 69: } catch (BackingStoreException e) { Line 70: log.warn("Failed to validate Os Repository due to " + e); -- To view, visit http://gerrit.ovirt.org/31372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d4a295768ccbed461b20efeaed8f69a06a3d42 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
