Martin Mucha has posted comments on this change. Change subject: webadmin: call&add name validation when creating/editing Provider URL for Network Provider ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31330/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java: Line 302: preSave(); Line 303: } Line 304: Line 305: private void onTest() { Line 306: if (!validate()) { > I wouldn't validate all UI fields, as only a subset affects the result of t Done Line 307: return; Line 308: } Line 309: Line 310: doTest(); -- To view, visit http://gerrit.ovirt.org/31330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b9e9a6b66d800c973334629fa34b3b5443290df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
