Roy Golan has posted comments on this change. Change subject: core: maxVCpus revised ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31439/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java: Line 169: vm.getVdsGroupCompatibilityVersion().getValue()); Line 170: Integer maxVCpus = Config.<Integer>getValue( Line 171: ConfigValues.MaxNumOfVmCpus, Line 172: vm.getVdsGroupCompatibilityVersion().getValue()); Line 173: maxVCpus = vm.getCpuPerSocket() * (Math.min(maxSockets, maxVCpus / vm.getCpuPerSocket())); > i assume we have validation for vm.getCpuPerSocket() > 0 ? AddVmCommand.java:419 Line 174: return maxVCpus; Line 175: } Line 176: Line 177: private void addCpuPinning(final String compatibilityVersion) { -- To view, visit http://gerrit.ovirt.org/31439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
