Sandro Bonazzola has posted comments on this change. Change subject: ovirt-image-uploader: Add creation of VDSM user ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31065/3/ovirt-image-uploader.spec.in File ovirt-image-uploader.spec.in: Line 32: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release} Line 33: BuildArch: noarch Line 34: Requires: python Line 35: Requires: python-lxml Line 36: Requires: shadow-utils > What is the practical meaning of changing this? it means you need shadow-utils while you're installing the rpm, but it's not needed at run-time by the package executable and libraries. Line 37: Requires: ovirt-engine-sdk-python >= 3.6.0.0 Line 38: Requires: logrotate Line 39: BuildRequires: gettext Line 40: BuildRequires: python2-devel -- To view, visit http://gerrit.ovirt.org/31065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58506d1a979201d2026c890a8ebbb9580827d50f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Lev Veyde <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
