Liran Zelkha has posted comments on this change. Change subject: core: Decrease updates to VdsDynamic ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/31437/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 792 Line 793 Line 794 Line 795 Line 796 > Why removing this one? It's double. Appears in line 803 http://gerrit.ovirt.org/#/c/31437/7/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java: Line 281: if (!dbData.equals(vdsDynamic)) { Line 282: dbData.setcpu_over_commit_time_stamp(vdsDynamic.getcpu_over_commit_time_stamp()); Line 283: if (dbData.equals(vdsDynamic)) { Line 284: // Update just the cpu_over_commit in the DB Line 285: updateCpuOverCommit(vdsDynamic.getId(), vdsDynamic.getcpu_over_commit_time_stamp()); > can we move it to statistics? Still checking. Only in a separate patch. I think the problem with this being updated allot is another bug which we need to pursue. Line 286: } else { Line 287: update(vdsDynamic); Line 288: } Line 289: } else { -- To view, visit http://gerrit.ovirt.org/31437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30711bc02adcc6ebbcac95d609da0fbc54f49cb2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
