Lior Vernia has posted comments on this change.

Change subject: webadmin: Reset status panel on redraw
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/30581/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java:

Line 220:         if (drop) {
Line 221:             onOperation(candidate, candidate.getCommand(op1, op2, 
allNics));
Line 222:         }
Line 223: 
Line 224:         // raise the candidate event only if it was changed or if a 
drop occurred
> Please fix the comment (remove the 'if drop occurred')
Done
Line 225:         if (!candidate.equals(currentCandidate) || !equals(op1, 
currentOp1) || !equals(op2, currentOp2)) {
Line 226:             currentCandidate = candidate;
Line 227:             currentOp1 = op1;
Line 228:             currentOp2 = op2;


-- 
To view, visit http://gerrit.ovirt.org/30581
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic110c6dd4198a03c3274dfbb9fe39a8687a9861a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to