Liron Aravot has posted comments on this change. Change subject: core: GetAllDisksByVmIdQuery - improved performance and avoid NPE ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/22506/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java: Line 130: } Line 131: Line 132: private static class DiskForVmRowMapper implements RowMapper<Disk> { Line 133: Line 134: public static DiskForVmRowMapper instance = new DiskForVmRowMapper(); > should be final Done Line 135: Line 136: private DiskForVmRowMapper() { Line 137: } Line 138: http://gerrit.ovirt.org/#/c/22506/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java: Line 149: vmDevice.setBootOrder(rs.getInt("boot_order")); Line 150: vmDevice.setSpecParams(SerializationFactory.getDeserializer() Line 151: .deserializeOrCreateNew(rs.getString("spec_params"), HashMap.class)); Line 152: vmDevice.setIsManaged(rs.getBoolean("is_managed")); Line 153: // note - those columns are being used also in DiskVmRowMapper, therefore any related > Please add a blank line somewhere here, it's hard to understand what "those Done Line 154: // change should be done there as well. Line 155: vmDevice.setIsPlugged(rs.getBoolean("is_plugged")); Line 156: vmDevice.setIsReadOnly(rs.getBoolean("is_readonly")); Line 157: vmDevice.setAlias(rs.getString("alias")); -- To view, visit http://gerrit.ovirt.org/22506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91d12ee535563204b5d6aaeb64ec6a7c23ea1a81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Anonymous Coward #1000524 Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
