Francesco Romani has uploaded a new change for review. Change subject: guest manager: simplify spawn_guest_monitors ......................................................................
guest manager: simplify spawn_guest_monitors this patch simplifies the implementation of the method with no functional changes. Change-Id: Ia7469d7dea0429bd19c71517fd934d47321d07af Signed-off-by: Francesco Romani <[email protected]> --- M mom/GuestManager.py 1 file changed, 7 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/mom refs/changes/94/31594/1 diff --git a/mom/GuestManager.py b/mom/GuestManager.py index badeddb..49c915a 100644 --- a/mom/GuestManager.py +++ b/mom/GuestManager.py @@ -51,14 +51,13 @@ "can't start", id) continue guest = GuestMonitor(self.config, info, self.hypervisor_iface) - if self.hypervisor_iface.attachMonitor(id, guest.collect, - guest.interval): - self._register_guest(guest) - else: - t = GuestMonitorThread(info, guest) - t.start() - if guest.isAlive(): - self._register_guest(guest, t) + thread = None + if not self.hypervisor_iface.attachMonitor(id, + guest.collect, + guest.interval): + thread = GuestMonitorThread(info, guest) + thread.start() + self._register_guest(guest, thread) def wait_for_guest_monitors(self): """ -- To view, visit http://gerrit.ovirt.org/31594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7469d7dea0429bd19c71517fd934d47321d07af Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
