Sandro Bonazzola has posted comments on this change. Change subject: packaging: pull vdsm-jsonrpc-java-1.0.2 ......................................................................
Patch Set 1: Code-Review-1 (1 comment) Requires http://gerrit.ovirt.org/31424 to be merged first. http://gerrit.ovirt.org/#/c/31566/1/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 547: Requires: %{name}-setup-plugin-ovirt-engine = %{version}-%{release} Line 548: Requires: openssh-server Line 549: Requires: ovirt-host-deploy >= 1.3.0 Line 550: Requires: ovirt-host-deploy-offline >= 1.3.0 Line 551: Requires: vdsm-jsonrpc-java >= 1.0.2 > sandro, why all-in-one needs explicit dependency on that? I'm not sure why it's there. I just updated the dependency I found there. It has been added on http://gerrit.ovirt.org/26783 and merged without me reviewing it. I haven't tested what happens removing this line. It has been verified, reviewed and approved so maybe someone of the involved people can answer. Line 552: Line 553: %description setup-plugin-allinone Line 554: All-in-one plugin for %{ovirt_product_name_short}'s setup Line 555: -- To view, visit http://gerrit.ovirt.org/31566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd7e932319fa5b07de2c05023d4fb1d5db97bad7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
