anmolbabu has posted comments on this change. Change subject: engine : Bll Query to get geo-rep status details ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/30528/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeGeoRepStatusDetailsPrameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeGeoRepStatusDetailsPrameters.java: Line 5: public class GlusterVolumeGeoRepStatusDetailsPrameters extends GlusterVolumeQueriesParameters { Line 6: Line 7: private static final long serialVersionUID = 1081721673083678394L; Line 8: Line 9: private Guid geoRepSessionId; > you could just call this as 'sessionId' There's one sessionId in the base class VdcQueryParametersBase(The identifier of session which should be set by sender via Rest Api or by front end).So, I thought it might be confusing to name it as sessionId.What would you opine Line 10: Line 11: public GlusterVolumeGeoRepStatusDetailsPrameters() { Line 12: Line 13: } -- To view, visit http://gerrit.ovirt.org/30528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If13b945fb21e36e4614bb95393aba71e57dba9be Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
