Tomas Jelinek has posted comments on this change. Change subject: ui: Remove default caption from Cloud-Init new network ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31019/1/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 2129: @DefaultStringValue("List can contain zero or more IP addresses separated by spaces, each in the form xxx.xxx.xxx.xxx") Line 2130: String cloudInitDnsServerListMessage(); Line 2131: Line 2132: @DefaultStringValue("") Line 2133: String cloudInitNewNetworkItem(); I don't think this item makes much sense when it is empty - I would delete the "cloudInitNewNetworkItem" from here and than in the VmInitModel.cloudInitNewNetworkItem would set it to "" directly. Line 2134: Line 2135: @DefaultStringValue("/path [Click to Change]") Line 2136: String cloudInitNewAttachmentItem(); Line 2137: -- To view, visit http://gerrit.ovirt.org/31019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I796812fedf425592b6f566047ad8ccbf29c9e50e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
