Martin Peřina has uploaded a new change for review. Change subject: webadmin: Fix Fencing Policy look ......................................................................
webadmin: Fix Fencing Policy look Fixes the look of Fencing Policy tab in Cluster detail popup. Change-Id: Ie1c4cb496bf3a324ecd311a03a090945c679060d Bug-Url: https://bugzilla.redhat.com/1120829 Bug-Url: https://bugzilla.redhat.com/1090799 Bug-Url: https://bugzilla.redhat.com/1120858 Signed-off-by: Martin Perina <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 3 files changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/31655/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java index aac7052..d69f145 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java @@ -555,6 +555,7 @@ return object.toString(); } }); + hostsWithBrokenConnectivityThresholdEditor.getContentWidgetContainer().setWidth("75px"); //$NON-NLS-1$ } private void initCheckBoxEditors() { @@ -578,13 +579,13 @@ rngHwrngSourceRequired = new EntityModelCheckBoxEditor(Align.RIGHT); fencingEnabledCheckBox = new EntityModelCheckBoxEditor(Align.RIGHT); - fencingEnabledCheckBox.getContentWidgetContainer().setWidth("300px"); //$NON-NLS-1$ + fencingEnabledCheckBox.getContentWidgetContainer().setWidth("150px"); //$NON-NLS-1$ skipFencingIfSDActiveCheckBox = new EntityModelCheckBoxEditor(Align.RIGHT); skipFencingIfSDActiveCheckBox.getContentWidgetContainer().setWidth("300px"); //$NON-NLS-1$ skipFencingIfConnectivityBrokenCheckBox = new EntityModelCheckBoxEditor(Align.RIGHT); - skipFencingIfConnectivityBrokenCheckBox.getContentWidgetContainer().setWidth("300px"); //$NON-NLS-1$ + skipFencingIfConnectivityBrokenCheckBox.getContentWidgetContainer().setWidth("305px"); //$NON-NLS-1$ } private void initInfoIcons(ApplicationResources resources, ApplicationConstants constants, ApplicationTemplates templates) { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml index 3311b7b2..bdd279f 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml @@ -276,15 +276,13 @@ <ge:EntityModelCheckBoxEditor ui:field="fencingEnabledCheckBox" /> <d:InfoIcon ui:field="fencingEnabledInfo" addStyleNames="cpv_fencingEnabledInfo_pfly_fix" /> </g:HorizontalPanel> - <g:HorizontalPanel> + <g:HorizontalPanel addStyleNames="cpv_skipFencingIfSDActiveInfo_line_pfly_fix"> <ge:EntityModelCheckBoxEditor ui:field="skipFencingIfSDActiveCheckBox" /> <d:InfoIcon ui:field="skipFencingIfSDActiveInfo" addStyleNames="cpv_skipFencingIfSDActiveInfo_pfly_fix" /> </g:HorizontalPanel> - <g:HorizontalPanel> + <g:HorizontalPanel addStyleNames="cpv_hostsWithBrokenConnectivityThresholdEditor_line_pfly_fix"> <ge:EntityModelCheckBoxEditor ui:field="skipFencingIfConnectivityBrokenCheckBox" /> <d:InfoIcon ui:field="skipFencingIfConnectivityBrokenInfo" /> - </g:HorizontalPanel> - <g:HorizontalPanel> <e:ListModelListBoxEditor ui:field="hostsWithBrokenConnectivityThresholdEditor" addStyleNames="cpv_hostsWithBrokenConnectivityThresholdEditor_pfly_fix" /> </g:HorizontalPanel> </g:FlowPanel> diff --git a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css index 6b17d25..93816f6 100644 --- a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css +++ b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css @@ -425,16 +425,26 @@ top: 5px; left: 5px; } +.cpv_skipFencingIfSDActiveInfo_line_pfly_fix { + position: relative; + left: 20px; + top: 5px; +} +.cpv_hostsWithBrokenConnectivityThresholdEditor_line_pfly_fix { + position: relative; + left: 20px; + top: 8px; + line-height: 40px; +} .cpv_skipFencingIfConnectivityBrokenInfo_pfly_fix { position: relative; top: 5px; left: 5px; - width: 30%; } .cpv_hostsWithBrokenConnectivityThresholdEditor_pfly_fix { position: relative; top: 5px; - left: 5px; + left: 20px; } .appv_searchButton_pfly_fix { position: relative !important; -- To view, visit http://gerrit.ovirt.org/31655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie1c4cb496bf3a324ecd311a03a090945c679060d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
