Arik Hadas has posted comments on this change. Change subject: core, db: Introduce CPU profile DAL ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31623/1/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/CpuProfileDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/CpuProfileDaoTest.java: Line 12: import org.ovirt.engine.core.compat.Guid; Line 13: import org.ovirt.engine.core.dao.BaseDAOTestCase; Line 14: import org.ovirt.engine.core.dao.FixturesTool; Line 15: Line 16: public class CpuProfileDaoTest extends BaseDAOTestCase { > it is better not to use Guid.newGuid so the test will be deterministic. the as it is common to set non-exiting GUIDs only in our REST API tests, I don't mind to keep it the way it is either.. Line 17: Line 18: private CpuProfile cpuProfile; Line 19: private CpuProfileDao dao; Line 20: -- To view, visit http://gerrit.ovirt.org/31623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d3b9d4737d523a722a688485e45d2a77775e2ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
