Allon Mureinik has posted comments on this change. Change subject: core: Use correct validation for SD selection ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/31488/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 76: private Guid memorySdId; Line 77: Line 78: /** The size for the snapshot's meta data which is vm related properties at the Line 79: * time the snapshot was taken */ Line 80: public static final long META_DATA_SIZE_IN_BYTES = 10 * 1024; Why public? Line 81: Line 82: protected CreateAllSnapshotsFromVmCommand(Guid commandId) { Line 83: super(commandId); Line 84: } http://gerrit.ovirt.org/#/c/31488/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageBuilder.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageBuilder.java: Line 7: void build(); Line 8: Line 9: /** Line 10: * Return the string representation of the memory volumes Line 11: * Unrelated to the patch - please remove Line 12: * @return string representation of the memory volumes Line 13: */ Line 14: String getVolumeStringRepresentation(); Line 15: Line 14: String getVolumeStringRepresentation(); Line 15: Line 16: /** Line 17: * Return whether this builder creates tasks in {@link #build()} Line 18: * Unrelated to the patch - please remove Line 19: * @return true if tasks are created in {@link #build()}, false otherwise Line 20: */ Line 21: boolean isCreateTasks(); -- To view, visit http://gerrit.ovirt.org/31488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac901a638358b9b08bcc6992d783a42cbfcd9bfa Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
