Yair Zaslavsky has posted comments on this change.

Change subject: core: Calculate Vds name from VdsStatic not VDS
......................................................................


Patch Set 3:

I am in favor of this, however,
I do wonder -
Have we you checked enough scenarios to see that we don't need something 
dynamic from audiot loggable as well, after we refer to the name that is static 
as well?
Can you elaborate a bit on the performance improvement results you have seen?
Thanks!

-- 
To view, visit http://gerrit.ovirt.org/31463
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b5f5445c4a7b986bfb983051a850b3794d25bfe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to