Allon Mureinik has posted comments on this change.

Change subject: core: adding logicalName to VmDevice
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/31673/1/backend/manager/modules/dal/src/test/resources/fixtures.xml
File backend/manager/modules/dal/src/test/resources/fixtures.xml:

Line 5881:             <value>true</value>
Line 5882:             <value>false</value>
Line 5883:             <value>alias</value>
Line 5884:             <null />
Line 5885:             <null />
Please have at least one test-case fixture with a device that DOES have a 
logical name
Line 5886:         </row>
Line 5887:      </table>
Line 5888: 
Line 5889:     <table name="job">


-- 
To view, visit http://gerrit.ovirt.org/31673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d36faa2912b5eba2e91fdcf74d7ca7b1c553117
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to