Jiří Moskovčák has uploaded a new change for review.

Change subject: use blank storage pool when creating the volumes
......................................................................

use blank storage pool when creating the volumes

We're not connected to a pool. To prepare an image when you're not
connected to a pool (general HE use case) you should specify a blank
pool uuid (00000000-0000-0000-0000-000000000000)

Change-Id: I3d7683b8dd10097344cb1d5fd036e549fc25ef8c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130038
Signed-off-by: Jiri Moskovcak <[email protected]>
---
M ovirt_hosted_engine_ha/lib/storage_backends.py
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-ha 
refs/changes/51/31751/1

diff --git a/ovirt_hosted_engine_ha/lib/storage_backends.py 
b/ovirt_hosted_engine_ha/lib/storage_backends.py
index a61da8f..a6655b3 100644
--- a/ovirt_hosted_engine_ha/lib/storage_backends.py
+++ b/ovirt_hosted_engine_ha/lib/storage_backends.py
@@ -251,7 +251,9 @@
         # Check of the volume already exists
         response = connection.getVolumePath(
             self._sd_uuid,
-            self._sp_uuid,
+            # we're not connected to any storage pool, so we need to use this
+            # special id suggested by fsimonce rhbz#1130038
+            '00000000-0000-0000-0000-000000000000',
             image_uuid,
             volume_uuid
         )
@@ -272,7 +274,7 @@
         # Create new volume
         create_response = connection.createVolume(
             self._sd_uuid,
-            self._sp_uuid,
+            '00000000-0000-0000-0000-000000000000',
             image_uuid,
             str(service_size),  # Need to be str for using bytes.
             self.RAW_FORMAT,
@@ -306,7 +308,7 @@
 
         response = connection.getVolumePath(
             self._sd_uuid,
-            self._sp_uuid,
+            '00000000-0000-0000-0000-000000000000',
             image_uuid,
             volume_uuid
         )


-- 
To view, visit http://gerrit.ovirt.org/31751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d7683b8dd10097344cb1d5fd036e549fc25ef8c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to