Idan Shaby has posted comments on this change. Change subject: core: WAD should be Ignored on File Domain Disks ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/31687/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SecureDeletionHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SecureDeletionHandler.java: Line 4: import org.ovirt.engine.core.common.vdscommands.SecureDeletion; Line 5: import org.ovirt.engine.core.common.vdscommands.StorageDomainIdParametersBase; Line 6: import org.ovirt.engine.core.dal.dbbroker.DbFacade; Line 7: Line 8: public class SecureDeletionHandler { > - I don't understand how enabling it for file domains affects the term, can You got a point. I am fixing it to PostZeroHandler and we'll let Sean decide on a new name. Line 9: Line 10: /** Line 11: * Since the file system is responsible for handling block allocation, there is no need Line 12: * for posting zeros on file domains. This method gets the parameters of a command that may Line 14: * @param parameters The parameters of the command that should be executed. Line 15: * @param <T> The parameters type. Line 16: * @return The fixed parameters. Line 17: */ Line 18: public static <T extends StorageDomainIdParametersBase & SecureDeletion> > what's the motivation for having this interface and not a parent class for It will be easier to remove, and requires less changes. Line 19: T fixParametersWithSecureDeletion(T parameters) { Line 20: StorageDomainStatic storageDomainStatic = Line 21: DbFacade.getInstance().getStorageDomainStaticDao().get(parameters.getStorageDomainId()); Line 22: return fixParametersWithSecureDeletion(parameters, storageDomainStatic.getStorageType().isFileDomain()); -- To view, visit http://gerrit.ovirt.org/31687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0df2c07282994557e149db922cc1d3a166c5aa8f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
