Eduardo has posted comments on this change. Change subject: agent: new implementation for nics' information function. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (4 inline comments) .................................................... File ovirt-guest-agent/GuestAgentLinux2.py Line 44: interfaces = list() interfaces = list[] is more clear. Line 45: try: Make this try clause shorter. Line 55: except: Don't do except. Line 63: self.list_nics = self.ethtool_list_nics lines 62-63 should not be in the try part. e.g. self.ethtool = ethtool can't raise if the import succed. -- To view, visit http://gerrit.ovirt.org/6183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cc663150cb1dc17e568fb429ea786b6baa4ca9e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
