Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Prevent more than one dwh per engine ......................................................................
Patch Set 7: (1 comment) > why is there too single_etl files? please provide clearer names. One is in setup and one is in remove. We have other such cases, e.g. service.py. I don't mind renaming, though. http://gerrit.ovirt.org/#/c/31325/7/packaging/setup/ovirt_engine_setup/dwh/engine_db_timekeeping.py File packaging/setup/ovirt_engine_setup/dwh/engine_db_timekeeping.py: Line 49: ).format( Line 50: name=name, Line 51: ) Line 52: ) Line 53: return result[0]['var_value'] if result else None > What if it's a date type variable or has both? I think it will be simplest to add new functions for that, if we need/want that. Line 54: Line 55: Line 56: def updateTimekeeping(statement, name, value): Line 57: getFromTimekeeping(statement, name, raise_if_empty=True) -- To view, visit http://gerrit.ovirt.org/31325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c0bbeef7fbd809895f4f0c1addd36e13f4894a6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
