Lior Vernia has posted comments on this change. Change subject: webadmin: set default plugin for provider ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/31763/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java: Line 117: } Line 118: }); Line 119: Line 120: getPluginType().setItems(NeutronPluginTranslator.getPresetDisplayStrings()); Line 121: getPluginType().setSelectedItem(getDefaultPluginTypeString()); //$NON-NLS-1$ The "//$NON-NLS-1$" comment can now be removed from here, this is only used to assert that a non-externalized string shouldn't break compilation. Line 122: getInterfaceMappingsLabel().setEntity(ConstantsManager.getInstance().getConstants().interfaceMappings()); Line 123: getInterfaceMappingsExplanation().setEntity(ConstantsManager.getInstance() Line 124: .getConstants() Line 125: .interfaceMappingsExplanation()); Line 144: } Line 145: Line 146: public void init(Provider<OpenstackNetworkProviderProperties> provider) { Line 147: OpenstackNetworkProviderProperties properties = provider.getAdditionalProperties(); Line 148: String pluginName = (properties == null) ? getDefaultPluginTypeString() : properties.getPluginType(); //$NON-NLS-1$ Same here. Line 149: getPluginType().setSelectedItem(NeutronPluginTranslator.getDisplayStringForPluginName(pluginName)); Line 150: Line 151: if (properties != null) { Line 152: AgentConfiguration agentConfiguration = properties.getAgentConfiguration(); -- To view, visit http://gerrit.ovirt.org/31763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52abd0ea1a6a923374e6ab094ff2a81f145f443a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <[email protected]> Gerrit-Reviewer: Eliraz Levi <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
