Vinzenz Feenstra has posted comments on this change. Change subject: db: add logical_name to vm_device ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31754/2/packaging/dbscripts/upgrade/03_06_0240_add_logical_name_to_vm_device.sql File packaging/dbscripts/upgrade/03_06_0240_add_logical_name_to_vm_device.sql: Line 1: select fn_db_add_column('vm_device', 'logical_name', 'VARCHAR(30) '); > you have extra space after (30), and why just 30? is it enough for any os? to be honest, I would not put my hand into the fire for making here a restriction to only 30. On windows I have seen already: \Device\Harddisk2\DR3 (21) and \\.\PhysicalDrive0 (18) Where the latter is more common from what I know. However this is already quite long. I would go for at least 128 if not even 255 characters. -- To view, visit http://gerrit.ovirt.org/31754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9b5a8e771a05c1fe44834adfe998cf921f6ae52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
