Alon Bar-Lev has posted comments on this change. Change subject: notifier: send sysUpTime in snmp notifications. ......................................................................
Patch Set 1: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/31916/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java: Line 20: import org.ovirt.engine.core.notifier.utils.NotificationProperties; Line 21: import org.snmp4j.CommunityTarget; Line 22: import org.snmp4j.PDU; Line 23: import org.snmp4j.mp.SnmpConstants; Line 24: import org.snmp4j.smi.*; really? you?!?!? :) Line 25: import org.snmp4j.transport.DefaultUdpTransportMapping; Line 26: Line 27: public class Snmp extends Transport { Line 28: Line 36: Line 37: private final Map<String, Profile> profiles = new HashMap<>(); Line 38: private org.snmp4j.Snmp snmp = null; Line 39: private boolean active = false; Line 40: private long nanoStart = System.nanoTime(); static? Line 41: Line 42: public Snmp(NotificationProperties props) { Line 43: for (Map.Entry<String, String> entry : props.getProperties().entrySet()) { Line 44: Matcher m = PROFILE_PATTERN.matcher(entry.getKey()); -- To view, visit http://gerrit.ovirt.org/31916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
