Omer Frenkel has posted comments on this change. Change subject: engine: Forbid Bootable and Shareable Disks ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31714/2/packaging/dbscripts/upgrade/03_05_0920_update_disk_bootable_shareable.sql File packaging/dbscripts/upgrade/03_05_0920_update_disk_bootable_shareable.sql: Line 5: UPDATE vm_device Line 6: SET boot_order = 0 Line 7: WHERE device_id IN (SELECT disk_id Line 8: FROM base_disks Line 9: WHERE boot AND shareable); this will probably cause these vms not to boot anymore, did you test what happens to these vms? Line 10: Line 11: UPDATE base_disks Line 12: SET boot = FALSE -- To view, visit http://gerrit.ovirt.org/31714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e221d6534b71db96d0c58442220d249b305079b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
