Liron Aravot has submitted this change and it was merged. Change subject: webadmin: isRemoveCommandAvailable() - removal of unneeded booleans ......................................................................
webadmin: isRemoveCommandAvailable() - removal of unneeded booleans isRemoveCommandAvailable() is storing the checks results into booleans and checks them all at each iteration. The booleans can be replaced with comments and we can return immediately when the result is known. Change-Id: I808275fb826e2d4fd154e87aa9730f4c57b53002 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131845 Signed-off-by: Liron Aravot <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I808275fb826e2d4fd154e87aa9730f4c57b53002 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
