Maor Lipchuk has uploaded a new change for review.

Change subject: core: Modify CDA message when adding connection to iSCSI bond
......................................................................

core: Modify CDA message when adding connection to iSCSI bond

Modify a CDA message to also indicate the use case when user adds a
connection which already exists in the iSCSI bond.

Change-Id: Id66ef71008ed67901c388c82ec47d954e4ac60d7
Signed-off-by: Maor Lipchuk <[email protected]>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M 
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M 
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/31980/1

diff --git 
a/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 
b/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
index 6ff7f8b..1e6abdf 100644
--- 
a/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
+++ 
b/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
@@ -1248,6 +1248,7 @@
 Possible reasons:\n\
     - They are not of type iSCSI.\n\
     - Their status is not one of the following: Unknown, Active. Inactive.\n\
+    - The connection which been added already exists in the iSCSI bond.\n\
     - They do not belong to the same Data Center as the specified iSCSI bond.
 ACTION_TYPE_FAILED_ISCSI_BOND_NETWORK_CANNOT_BE_REQUIRED=Cannot ${action} 
${type}. Required network cannot be a part of an iSCSI bond.
 
diff --git 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
index 027b11d..4f86e60 100644
--- 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
+++ 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
@@ -3334,6 +3334,7 @@
             "Possible reasons:\n" +
             "- They are not of type iSCSI.\n" +
             "- Their status is not one of the following: Unknown, Active. 
Inactive.\n" +
+            "- The connection which been added already exists in the iSCSI 
bond.\n" +
             "- They do not belong to the same Data Center as the specified 
iSCSI bond.\n")
     String 
ACTION_TYPE_FAILED_STORAGE_CONNECTIONS_CANNOT_BE_ADDED_TO_ISCSI_BOND();
 
diff --git 
a/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
 
b/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
index 86b833d..48919a7 100644
--- 
a/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
+++ 
b/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
@@ -1033,6 +1033,7 @@
 Possible reasons:\n\
     - They are not of type iSCSI.\n\
     - Their status is not one of the following: Unknown, Active. Inactive.\n\
+    - The connection which been added already exists in the iSCSI bond.\n\
     - They do not belong to the same Data Center as the specified iSCSI bond.
 ACTION_TYPE_FAILED_ISCSI_BOND_NETWORK_CANNOT_BE_REQUIRED=Cannot ${action} 
${type}. Required network cannot be a part of an iSCSI bond.
 
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
index 90f2c74..88153f9 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
+++ 
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
@@ -1214,6 +1214,7 @@
 Possible reasons:\n\
     - They are not of type iSCSI.\n\
     - Their status is not one of the following: Unknown, Active. Inactive.\n\
+    - The connection which been added already exists in the iSCSI bond.\n\
     - They do not belong to the same Data Center as the specified iSCSI bond.
 ACTION_TYPE_FAILED_ISCSI_BOND_NETWORK_CANNOT_BE_REQUIRED=Cannot ${action} 
${type}. Required network cannot be a part of an iSCSI bond.
 


-- 
To view, visit http://gerrit.ovirt.org/31980
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id66ef71008ed67901c388c82ec47d954e4ac60d7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to