Maor Lipchuk has posted comments on this change. Change subject: core: Initialize internal lists in IscsiBond ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31859/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetIscsiBondByIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetIscsiBondByIdQuery.java: Line 10: } Line 11: Line 12: @Override Line 13: protected void executeQueryCommand() { Line 14: IscsiBond iscsiBond = getDbFacade().getIscsiBondDao().get(getParameters().getId()); > You need to check that a bond was returned here, and if not, just terminate done Line 15: iscsiBond.getNetworkIds().addAll(getDbFacade().getIscsiBondDao().getNetworkIdsByIscsiBondId(iscsiBond.getId())); Line 16: iscsiBond.getStorageConnectionIds().addAll(getDbFacade().getIscsiBondDao().getStorageConnectionIdsByIscsiBondId(iscsiBond.getId())); Line 17: getQueryReturnValue().setReturnValue(iscsiBond); Line 18: } -- To view, visit http://gerrit.ovirt.org/31859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I167b1c6d6c5f83022c18faad555c0ff2e6f1f44b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
