Alon Bar-Lev has posted comments on this change. Change subject: notifier: send sysUpTime in snmp notifications. ......................................................................
Patch Set 3: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/31916/3/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java: Line 107: } Line 108: OID trapOID = SnmpConstants.getTrapOID(profile.oid, ENTERPRISE_SPECIFIC, auditLogTypeVal); Line 109: v2pdu.add(new VariableBinding(SnmpConstants.snmpTrapOID, trapOID)); Line 110: v2pdu.add(new VariableBinding(SnmpConstants.sysUpTime, Line 111: new TimeTicks((System.nanoTime() - nanoStart) / 10000000))); please re-confirm that upstream formal documentation is wrong and you are right[1] [1] http://www.snmp4j.org/doc/org/snmp4j/package-summary.html Line 112: v2pdu.add(new VariableBinding( Line 113: new OID(trapOID).append(0), Line 114: new OctetString(event.getMessage()))); Line 115: v2pdu.add(new VariableBinding( -- To view, visit http://gerrit.ovirt.org/31916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
