Daniel Erez has uploaded a new change for review. Change subject: webadmin: fix style misalignments in block domain view ......................................................................
webadmin: fix style misalignments in block domain view Some alignment issues were introduced in block storage dialog and DirectLUN disk dialog (lists/tabs/etc) - see attached screenshots in BZ. Change-Id: I21975fb1fb5193322bf0e0d3565cc03767a4052c Bug-Url: https://bugzilla.redhat.com/1133779 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 6 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/32017/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java index 4ab675b..fbdc71c 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java @@ -673,7 +673,7 @@ iscsiStorageModel.setIsGrouppedByTarget(true); iscsiStorageModel.setIgnoreGrayedOut(true); - iscsiStorageView = new IscsiStorageView(false, 107, 201, 240, 275, 135, 55, -62); + iscsiStorageView = new IscsiStorageView(false, 102, 201, 244, 275, 142, 55, -67); iscsiStorageView.edit(iscsiStorageModel); // Create FcpStorageModel @@ -682,7 +682,7 @@ fcpStorageModel.getPropertyChangedEvent().addListener(progressEventHandler); fcpStorageModel.setIsGrouppedByTarget(false); fcpStorageModel.setIgnoreGrayedOut(true); - fcpStorageView = new FcpStorageView(false, 266, 240); + fcpStorageView = new FcpStorageView(false, 278, 240); fcpStorageView.edit(fcpStorageModel); // Set 'StorageModel' items diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml index 616a8c9..1b4af6b 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml @@ -69,7 +69,7 @@ .externalDiskPanel { height: 298px; width: 100%; - bottom: 0px; + bottom: 12px; position: absolute; } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java index 47e58a1..1f1a3f7 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java @@ -14,7 +14,7 @@ SanStorageLunToTargetList sanStorageLunToTargetList; - double panelHeight = 365; + double panelHeight = 378; double listHeight = 340; public FcpStorageView(boolean multiSelection) { diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java index fbebc17..4eecd4c 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java @@ -67,9 +67,9 @@ @Ignore IscsiLunToTargetView iscsiLunToTargetView; - private double treeCollapsedHeight = 206, treeExpandedHeight = 306, lunsTreeHeight = 341; - private double tabContentHeight = 340, tabHeight = 187; - private double textTop = 80, textLeft = -90; + private double treeCollapsedHeight = 206, treeExpandedHeight = 305, lunsTreeHeight = 348; + private double tabContentHeight = 340, tabHeight = 194; + private double textTop = 80, textLeft = -92; private final Driver driver = GWT.create(Driver.class); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java index 24a5904..9d6a79f 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java @@ -104,7 +104,7 @@ public String getValue(SanTargetModel model) { return ""; //$NON-NLS-1$ } - }, constants.empty(), "35px"); //$NON-NLS-1$ + }, constants.empty(), "30px"); //$NON-NLS-1$ table.addColumn(new TextColumn<SanTargetModel>() { @Override public String getValue(SanTargetModel model) { @@ -134,12 +134,12 @@ } }); loginButton.getElement().getStyle().setFloat(Float.RIGHT); - loginButton.getElement().getStyle().setMarginRight(2, Unit.PX); - loginButton.getElement().getStyle().setProperty("lineHeight", "20px"); //$NON-NLS-1$ //$NON-NLS-2$ + loginButton.getElement().getStyle().setMarginRight(6, Unit.PX); + loginButton.getElement().getElementsByTagName("span").getItem(0).getStyle().setMarginTop(0, Unit.PX); //$NON-NLS-1$ panel.add(loginButton); panel.setCellVerticalAlignment(loginButton, HasVerticalAlignment.ALIGN_MIDDLE); - panel.setCellWidth(loginButton, "30px"); //$NON-NLS-1$ + panel.setCellWidth(loginButton, "35px"); //$NON-NLS-1$ } private void additemToRootNodePanel(HorizontalPanel panel, diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml index fbb2a8a..9e1463f 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml @@ -87,7 +87,7 @@ </ui:style> - <d:SimpleDialogPanel width="760px" height="625px"> + <d:SimpleDialogPanel width="760px" height="635px"> <d:content> <g:FlowPanel addStyleNames="{style.content}"> <g:HorizontalPanel> -- To view, visit http://gerrit.ovirt.org/32017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I21975fb1fb5193322bf0e0d3565cc03767a4052c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
