Yaniv Bronhaim has uploaded a new change for review. Change subject: Checking isProvisioned instead of the redundant entity isDiscovered ......................................................................
Checking isProvisioned instead of the redundant entity isDiscovered isDiscovered was a mistake which checked only the textbox entity. The entity is filled with value when there are discovered host, so that check was wrong. This patch checks if the flow is for discovered or provisioning based on the isProvisioned entity, which is set when changing the radio buttons. Change-Id: Iee2f17c2aee18a1a619551a491af56075ae8cdc5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133540 Signed-off-by: Yaniv Bronhaim <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 2 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/21/32021/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java index 33bbca0..8c4952b 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java @@ -992,7 +992,7 @@ parameters.setNetworkMappings(model.getInterfaceMappings().getEntity()); } - if (model.getIsProvisioning()) { + if (model.getIsDiscorveredHosts().getEntity()) { Provider<?> provider = (Provider<?>) model.getProviders().getSelectedItem(); ExternalHostGroup hostGroup = (ExternalHostGroup) model.getExternalHostGroups().getSelectedItem(); ExternalComputeResource computeResource = (ExternalComputeResource) model.getExternalComputeResource().getSelectedItem(); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java index 9f98fe7..8bdc6ad 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java @@ -93,8 +93,6 @@ return getHostId() == null; } - public boolean getIsProvisioning() { return getExternalDiscoveredHosts().getSelectedItem() != null; } - private Guid privateHostId; public Guid getHostId() -- To view, visit http://gerrit.ovirt.org/32021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iee2f17c2aee18a1a619551a491af56075ae8cdc5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
