Oved Ourfali has uploaded a new change for review. Change subject: core: Do not suppress dismissed alerts ......................................................................
core: Do not suppress dismissed alerts No health check alert is issued in ui after first message was issued This patch fixed a problem when an alert is dismissed by the user. Current functionality did not addressed dismissed alerts and show for each host instance one alert from each type. In the case that the alert was dismissed by the user, it will not show again. This patch fix the SP that insert to audit log not to suppress the alert in case that the alert exists for the host instance but it was dismissed by the user (delete=true in audit_log table) Change-Id: Ie831e8ec49b81bcb49f106f2fb377cff4dc4566b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133611 Signed-off-by: Eli Mesika <[email protected]> (cherry picked from commit 57cb88b9b75e705504fd738dbcc1b9d4eac092c3) --- M packaging/dbscripts/audit_log_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/32026/1 diff --git a/packaging/dbscripts/audit_log_sp.sql b/packaging/dbscripts/audit_log_sp.sql index 714c053..ff139e5 100644 --- a/packaging/dbscripts/audit_log_sp.sql +++ b/packaging/dbscripts/audit_log_sp.sql @@ -42,7 +42,7 @@ v_audit_log_id := CURRVAL('audit_log_seq'); else - if (not exists(select audit_log_id from audit_log where vds_name = v_vds_name and log_type = v_log_type)) then + if (not exists(select audit_log_id from audit_log where vds_name = v_vds_name and log_type = v_log_type and not deleted)) then INSERT INTO audit_log(LOG_TIME, log_type, log_type_name, severity,message, user_id, USER_NAME, vds_id, VDS_NAME, vm_id, VM_NAME,vm_template_id,VM_TEMPLATE_NAME,storage_pool_id,STORAGE_POOL_NAME,storage_domain_id,STORAGE_DOMAIN_NAME,vds_group_id,vds_group_name, correlation_id, job_id, quota_id, quota_name, gluster_volume_id, gluster_volume_name, call_stack) VALUES(v_log_time, v_log_type, v_log_type_name, v_severity, v_message, v_user_id, v_user_name, v_vds_id, v_vds_name, v_vm_id, v_vm_name,v_vm_template_id,v_vm_template_name,v_storage_pool_id,v_storage_pool_name,v_storage_domain_id,v_storage_domain_name,v_vds_group_id,v_vds_group_name, v_correlation_id, v_job_id, v_quota_id, v_quota_name, v_gluster_volume_id, v_gluster_volume_name, v_call_stack); -- To view, visit http://gerrit.ovirt.org/32026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie831e8ec49b81bcb49f106f2fb377cff4dc4566b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
