Tal Nisan has uploaded a new change for review. Change subject: webadmin: Added a validator for entities of type Long ......................................................................
webadmin: Added a validator for entities of type Long Change-Id: Ib11197067707867657c98f8a7bb8695a659925d6 Signed-off-by: Tal Nisan <[email protected]> Bug-Url: https://bugzilla.redhat.com/1115471 --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LongValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 2 files changed, 61 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/32049/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LongValidation.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LongValidation.java new file mode 100644 index 0000000..aeca058 --- /dev/null +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LongValidation.java @@ -0,0 +1,58 @@ +package org.ovirt.engine.ui.uicommonweb.validation; + +import org.ovirt.engine.ui.uicompat.ConstantsManager; + +public class LongValidation implements IValidation { + private long maximum; + + public long getMaximum() { + return maximum; + } + + public void setMaximum(long value) { + maximum = value; + } + + private long minimum; + + public long getMinimum() { + return minimum; + } + + public void setMinimum(long value) { + minimum = value; + } + + public LongValidation() { + setMaximum(Long.MAX_VALUE); + setMinimum(Long.MIN_VALUE); + } + + @Override + public ValidationResult validate(Object value) { + ValidationResult result = new ValidationResult(); + + if (value != null && ((value instanceof String && !((String) value).trim().isEmpty()) || value instanceof Long)) + { + Long longValue; + if (value instanceof String) { + try { + longValue = Long.parseLong((String) value); + } + catch (NumberFormatException e) { + longValue = null; + } + } + else { + longValue = (Long) value; + } + + String msg = ConstantsManager.getInstance().getMessages().longValidationNumberInvalidReason(getMinimum(), getMaximum()); + if (longValue == null || longValue < getMinimum() || longValue > getMaximum()) { + result.setSuccess(false); + result.getReasons().add(msg); + } + } + return result; + } +} diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java index 00911ba..a80f136 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java @@ -39,6 +39,9 @@ @DefaultMessage("{0} less than or equal to {1}.") String integerValidationNumberLessInvalidReason(String prefixMsg, int max); + @DefaultMessage("This field must contain a number between {0} and {1}.") + String longValidationNumberInvalidReason(long min, long max); + @DefaultMessage("Field content must not exceed {0} characters.") String lenValidationFieldMusnotExceed(int maxLength); -- To view, visit http://gerrit.ovirt.org/32049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib11197067707867657c98f8a7bb8695a659925d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
