Tomas Jelinek has posted comments on this change. Change subject: engine: don't allow to create VM with balloon on ppc64 ......................................................................
Patch Set 3: (4 comments) please add the corresponding logic also the the template related commands (AddVmTemplateCommand,UpdateVmTemplateCommand). But be careful, you have to add that into the "doClusterRelatedChecks()" to avoid problems with instance types. And also please make sure that also the pool is working (it should) http://gerrit.ovirt.org/#/c/32038/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 471: Line 472: if (isBalloonEnabled() && !osRepository.isBalloonEnabled(getParameters().getVmStaticData().getOsId(), Line 473: getVdsGroup().getcompatibility_version())) { Line 474: return failCanDoAction(VdcBllMessages.BALLOON_REQUESTED_ON_NOT_SUPPORTED_ARCH, Line 475: String.format("$clusterArch %1$s", getVdsGroup().getArchitecture())); please use addCanDoActionMessageVariable("clusterArch", getVdsGroup().getArchitecture()); instead of string format Line 476: } Line 477: Line 478: // otherwise.. Line 479: storageToDisksMap = http://gerrit.ovirt.org/#/c/32038/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 211: OsRepository osRepository = SimpleDependecyInjector.getInstance().get(OsRepository.class); Line 212: if (getVdsGroup() != null && getVm().isBalloonEnabled() && !osRepository.isBalloonEnabled(getVm().getStaticData().getOsId(), Line 213: getVdsGroup().getcompatibility_version())) { Line 214: return failCanDoAction(VdcBllMessages.BALLOON_REQUESTED_ON_NOT_SUPPORTED_ARCH, Line 215: String.format("$clusterArch %1$s", getVdsGroup().getArchitecture())); same Line 216: } Line 217: Line 218: return canDoActionAfterCloneVm(domainsMap); Line 219: } http://gerrit.ovirt.org/#/c/32038/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 558: Line 559: if (isBalloonEnabled() && !osRepository.isBalloonEnabled(getParameters().getVmStaticData().getOsId(), Line 560: getVdsGroup().getcompatibility_version())) { Line 561: return failCanDoAction(VdcBllMessages.BALLOON_REQUESTED_ON_NOT_SUPPORTED_ARCH, Line 562: String.format("$clusterArch %1$s", getVdsGroup().getArchitecture())); same Line 563: } Line 564: Line 565: return true; Line 566: } http://gerrit.ovirt.org/#/c/32038/3/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3370: Line 3371: @DefaultStringValue("Cannot ${action} ${type}. Target cluster belongs to different Data Center.") Line 3372: String VDS_CLUSTER_ON_DIFFERENT_STORAGE_POOL(); Line 3373: Line 3374: @DefaultStringValue("Cannot ${action} ${type}. Balloon is not supported on '${VdsName}'.") the messages in the propery file and here should correspond, e.g: "Cannot ${action} ${type}. Balloon is not supported on '${clusterArch}' architecture.". Line 3375: String BALLOON_REQUESTED_ON_NOT_SUPPORTED_ARCH(); -- To view, visit http://gerrit.ovirt.org/32038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
