Alon Bar-Lev has uploaded a new change for review.

Change subject: extapi: ExtMap.get() allow null default value
......................................................................

extapi: ExtMap.get() allow null default value

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I2ad729b4e271d1b594fcd1485bd61667f6cbd2a1
Signed-off-by: Alon Bar-Lev <[email protected]>
---
M 
backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/32224/1

diff --git 
a/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java
 
b/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java
index ab78e69..13c3371 100644
--- 
a/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java
+++ 
b/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java
@@ -390,7 +390,7 @@
      * @return Value.
      */
     public <T> T get(ExtKey key, T defaultValue) {
-        if (!key.getType().isAssignableFrom(defaultValue.getClass())) {
+        if (defaultValue != null && 
!key.getType().isAssignableFrom(defaultValue.getClass())) {
             throw new IllegalArgumentException(
                 String.format(
                     "Cannnot assign default value of '%s' into type '%s'",


-- 
To view, visit http://gerrit.ovirt.org/32224
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ad729b4e271d1b594fcd1485bd61667f6cbd2a1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to