Gilad Chaplik has posted comments on this change. Change subject: webadmin: check explicitly if isDiscovered is equal to true ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32268/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 991: parameters.setNetworkProviderId(networkProvider.getId()); Line 992: parameters.setNetworkMappings(model.getInterfaceMappings().getEntity()); Line 993: } Line 994: Line 995: if (Boolean.TRUE.equals(model.getIsDiscorveredHosts().getEntity())) { instead of that, initialize entity in HostModel.java setDiscorveredHosts(new EntityModel<Boolean>()); + getIsDiscorveredHosts().setEntity(false); Line 996: Provider<?> provider = (Provider<?>) model.getProviders().getSelectedItem(); Line 997: ExternalHostGroup hostGroup = (ExternalHostGroup) model.getExternalHostGroups().getSelectedItem(); Line 998: ExternalComputeResource computeResource = (ExternalComputeResource) model.getExternalComputeResource().getSelectedItem(); Line 999: ExternalDiscoveredHost discoveredHost = (ExternalDiscoveredHost)model.getExternalDiscoveredHosts().getSelectedItem(); -- To view, visit http://gerrit.ovirt.org/32268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide820aa4d51bfc92414d2515d8d1eeb0551a18ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
