Yair Zaslavsky has posted comments on this change. Change subject: core: Make Job monitoring feature to work via asynchronius queue ......................................................................
Patch Set 1: (2 inline comments) 1. Minor typos in commit message - please fix. 2. General design/functionality - looks good. A question here - why not simply use the method names, and not introdoucing an enum for the methods? (Why not pass the object and the method name to be invoked on? this is another possibility) This can save the switch. I hope I'm clear here. 3. Please open a ticket for pre-integration on this. .................................................... Commit Message Line 11: a hevy load on the same couple of tables, the idea is to perfrom an insert, update of jobs and steps in hevy = heavy Line 13: For these purpose was used a non blocking queue which will keep events and addional thread will perfrom a writing of events For this purpose a non blocking queue which will..... .... is introduced. -- To view, visit http://gerrit.ovirt.org/6457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e0a5e858ff348eb9dfe9edf2fe15500d743f62d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
