Yevgeny Zaspitsky has posted comments on this change. Change subject: core: coverity issue fix. ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31206/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java: Line 80: return range; Line 81: } Line 82: } Line 83: Line 84: if (failIfNotExist) { 1. I'd apply this logic in the place it is needed (only one of two). That will make the failIfNotExist redundant. 2. Please use org.apache.commons.lang.Validate.notNull method instead. Line 85: throw new IllegalStateException(); Line 86: } else { Line 87: return null; Line 88: } -- To view, visit http://gerrit.ovirt.org/31206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8a06231c6151530ff6c0fee9614b45f39c3a1dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
