Piotr Kliczewski has posted comments on this change. Change subject: core: NPE when getVMFullList returns no vm information ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32288/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java: Line 17: private static final String VM_LIST = "vmList"; Line 18: private static final Map<String, Object>[] EMPTY_ARRAY_MAP = new HashMap[0]; Line 19: Line 20: public StatusForXmlRpc mStatus; Line 21: public Map<String, Object>[] mVmList = EMPTY_ARRAY_MAP; > naming: MAP_ARRAY rather than ARRAY_MAP it is an array of maps not the opposite. Line 22: Line 23: public VMListReturnForXmlRpc(Map<String, Object> innerMap) { Line 24: mStatus = new StatusForXmlRpc((Map<String, Object>) innerMap.get(STATUS)); Line 25: Object[] temp = (Object[]) innerMap.get(VM_LIST); -- To view, visit http://gerrit.ovirt.org/32288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefbf71dd19bc6c759f1ef2ac02a2f6136146989f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
