Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: edit pool dialog freezes when when SD is down (#839594) ......................................................................
webadmin: edit pool dialog freezes when when SD is down (#839594) https://bugzilla.redhat.com/839594 Have a pool on a storage domain which is down. Go to pool tab, press edit. The window will stack forever. Fixed in a way, that the dialog opens the same way as if the SD would not be down. When the OK button is pressed, an error comes back from the server. Fixed by avoiding NPEs and ClassCastExceptions on different places. This patch also refactors the Edit method to use the GetVmDataByPoolId query, which is more efficient than the AsyncDataProvider.GetVmList and selecting the first element. Change-Id: Ic9635873a04c71bdf94a011a27dd47cb5c9b259b Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java 2 files changed, 248 insertions(+), 216 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/6480/1 -- To view, visit http://gerrit.ovirt.org/6480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic9635873a04c71bdf94a011a27dd47cb5c9b259b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
