Gilad Chaplik has posted comments on this change.
Change subject: core: refactoring quota CRUD commands
......................................................................
Patch Set 3: (12 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java
Line 16: protected void executeCommand() {
Done
Line 17: // TODO Auto-generated method stub
Done
Line 22: public List<PermissionSubject> getPermissionCheckSubjects() {
Done
Line 36: return DbFacade.getInstance().getQuotaDAO();
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java
Line 24: setQuota(getQuotaDAO().getById(getParameters().getQuotaId()));
I need it in the canDoAction also
Line 77:
QuotaManager.getInstance().removeQuotaFromCache(getQuota().getStoragePoolId(),
getParameters().getQuotaId());
I will add a method in commandBase getQuotaManager, there I will return the
instance.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java
Line 49:
QuotaManager.getInstance().removeQuotaFromCache(getQuota().getStoragePoolId(),
getQuota().getId());
yes, I need to fetch it from the DB to sync the cache
Line 59: : getQuota().getId().getValue(),
I hope to get to it.
Line 86: quotaStorage.setQuotaId(getQuota().getId());
Done
Line 92: quotaVdsGroup.setQuotaId(getQuota().getId());
Done
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddQuotaCommandTest.java
Line 39: private final Guid storagePoolUUID = Guid.NewGuid();
Done
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java
Line 61: List<VM> newList = new ArrayList<VM>();
I guess so, something points to it.
tests will be handled later.
--
To view, visit http://gerrit.ovirt.org/6302
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78124bce99bad0d716e711b6dd76e9c763affbc6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
