Gilad Chaplik has posted comments on this change. Change subject: engine: don't allow to create VM with balloon on ppc64 ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/32038/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 472: if (isBalloonEnabled() && !osRepository.isBalloonEnabled(getParameters().getVmStaticData().getOsId(), Line 473: getVdsGroup().getcompatibility_version())) { Line 474: addCanDoActionMessageVariable("clusterArch", getVdsGroup().getArchitecture()); Line 475: return failCanDoAction(VdcBllMessages.BALLOON_REQUESTED_ON_NOT_SUPPORTED_ARCH); Line 476: } * isBallonEnabled() looks exactly the same (except for err msg). * Consider having a util method for this section and use it in all places, will be easier to later enhance/fix stuff. * the check here is for osId, and the err msg includes the architecture, I'm a bit confused :-) Line 477: Line 478: // otherwise.. Line 479: storageToDisksMap = Line 480: ImagesHandler.buildStorageToDiskMap(getImagesToCheckDestinationStorageDomains(), -- To view, visit http://gerrit.ovirt.org/32038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
